Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PoS VP panic::catch_unwind #21

Closed
Tracked by #2006
tzemanovic opened this issue Sep 13, 2021 · 2 comments · Fixed by #2145
Closed
Tracked by #2006

Remove PoS VP panic::catch_unwind #21

tzemanovic opened this issue Sep 13, 2021 · 2 comments · Fixed by #2145
Assignees
@brentstone
Labels
ledger PoS
Milestone
0.15

Comments

@tzemanovic
Copy link
Member

tzemanovic commented Sep 13, 2021 •
edited by sync-by-unito bot
Loading

Depends on #12, anoma/anoma#435 and #17

Remove the temporary measure in apps/src/lib/node/ledger/protocol/mod.rs and UnwindSafe + RefUnwindSafe impls in shared/src/ledger/pos/vp.rs that runs the PoS VP in a new thread to catch panics.

┆Issue is synchronized with this Asana task by Unito
@tzemanovic tzemanovic added the PoS label Sep 13, 2021
@tzemanovic tzemanovic mentioned this issue Sep 13, 2021
Merged
@tzemanovic tzemanovic mentioned this issue Nov 8, 2021
Closed
@sync-by-unito sync-by-unito bot closed this as completed Feb 3, 2022
@juped juped reopened this Feb 3, 2022
@tzemanovic tzemanovic transferred this issue from anoma/anoma Jul 7, 2022
@cwgoes
Copy link
Contributor

cwgoes commented Jan 12, 2023

@brentstone do you know if this is still applicable?

@tzemanovic
Copy link
Member Author

we still have this in

@cwgoes cwgoes added this to the 0.15 milestone Jan 16, 2023
@cwgoes cwgoes mentioned this issue Oct 20, 2023
Closed
41 tasks
@tzemanovic tzemanovic mentioned this issue Nov 10, 2023
Merged
2 tasks
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
@memasdeligeorgakis
Merge pull request anoma#21 from heliaxdev/feat/17/settings_accounts_…
396c113 
…and_navigation

# 17 settings/accounts screen and navigation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brentstone brentstone

Labels
ledger PoS
Projects
No open projects
Namada-Old
Status: Tested in Devnet
Milestone
0.15
Development

Successfully merging a pull request may close this issue.

protocol: remove panic::catch_unwind for PoS VP anoma/namada
4 participants
@juped @tzemanovic @cwgoes @brentstone