Merge branch 'fraccaman/fix-proposal-loading' (#2679)

* origin/fraccaman/fix-proposal-loading:
  added changelog
  use btreeset instead of hashset

.changelog/unreleased/bug-fixes/2679-fix-proposal-loading.md

@@ -0,0 +1,2 @@
+- Fixing the order of proposal execution to be deterministic.
+  ([\#2679](https://github.com/anoma/namada/pull/2679))

crates/apps/src/lib/node/ledger/shell/finalize_block.rs

@@ -858,7 +858,7 @@ fn pos_votes_from_abci(
 /// are covered by the e2e tests.
 #[cfg(test)]
 mod test_finalize_block {
-    use std::collections::{BTreeMap, BTreeSet, HashMap};
+    use std::collections::{BTreeMap, BTreeSet, HashMap, HashSet};
     use std::num::NonZeroU64;
     use std::str::FromStr;
 

crates/apps/src/lib/node/ledger/shell/mod.rs

@@ -21,7 +21,7 @@ pub mod testing;
 pub mod utils;
 mod vote_extensions;
 
-use std::collections::{BTreeSet, HashSet};
+use std::collections::BTreeSet;
 use std::convert::{TryFrom, TryInto};
 use std::mem;
 use std::path::{Path, PathBuf};
@@ -357,7 +357,7 @@ where
     /// queried for reading values.
     storage_read_past_height_limit: Option<u64>,
     /// Proposal execution tracking
-    pub proposal_data: HashSet<u64>,
+    pub proposal_data: BTreeSet<u64>,
     /// Log of events emitted by `FinalizeBlock` ABCI calls.
     event_log: EventLog,
 }
@@ -533,7 +533,7 @@ where
                 tx_wasm_compilation_cache as usize,
             ),
             storage_read_past_height_limit,
-            proposal_data: HashSet::new(),
+            proposal_data: BTreeSet::new(),
             // TODO: config event log params
             event_log: EventLog::default(),
         };