feat: add dynamic unbound period #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euharrison
requested review from
mateuszjasiuk,
pedrorezende and
emccorson
and removed request for
mateuszjasiuk
euharrison
commented
Aug 9, 2024
| unbondingPeriodInEpochs, | ||
| minEpochDuration, | ||
| }: EpochInfo): number => { | ||
| const duration = unbondingPeriodInEpochs * minEpochDuration; |
There was a problem hiding this comment.
Could someone confirm if this calculation is correct?
There was a problem hiding this comment.
I did some calculation these last days using and it looks correct :)
jurevans
reviewed
Aug 16, 2024
| @@ -141,6 +152,9 @@ const Unstake = (): JSX.Element => { | |||
| return ""; | |||
| })(); | |||
|
|
|||
| const unboundPeriod = | |||
There was a problem hiding this comment.
Small thing: could we change instances of unboundPeriod to unbondPeriod for consistency, and rename getUboundingPeriod to getUnbondingPeriod? Might be a little more clear, matching the definition in EpochInfo
There was a problem hiding this comment.
ops, yes, thanks! done :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #973
Add dynamic unbound period