Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix broken "Back Up My Wallet" extension link #961

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

emccorson
Copy link
Collaborator

Fixes #960.

Copy link

github-actions bot commented Aug 5, 2024

@github-actions github-actions bot temporarily deployed to pull request August 5, 2024 01:58 Inactive
@emccorson emccorson marked this pull request as ready for review August 5, 2024 03:01
@euharrison
Copy link
Contributor

Thinking loud, we could explore an alternative of exporting only the classname of <LinkButton> then use it directly on the <Link> component, on the DeleteAccount

Or, we could accept the idea of importing react-router on the root of the monorepo, then the <Link> component could be used by <LinkButton>

@emccorson emccorson merged commit ad5c962 into main Aug 7, 2024
7 checks passed
@mateuszjasiuk mateuszjasiuk deleted the back-up-my-wallet-link branch September 13, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension: "Back Up My Wallet" link when deleting keys doesn't work
2 participants