Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update namada to draft/0.22 #360

Merged
merged 7 commits into from
Sep 7, 2023
Merged

chore: update namada to draft/0.22 #360

merged 7 commits into from
Sep 7, 2023

Conversation

mateuszjasiuk
Copy link
Collaborator

@mateuszjasiuk mateuszjasiuk commented Aug 8, 2023 •
edited by jurevans
Loading

No description provided.

@mateuszjasiuk mateuszjasiuk changed the title chore: update namada to 0.21.0 WIP: chore: update namada to 0.21.0 Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023 •
edited
Loading

🚀 Deployed on https://pull-request-360--wallet-development-heliax-dev.netlify.app

@github-actions github-actions bot temporarily deployed to pull request August 8, 2023 10:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 8, 2023 11:42 Inactive
@mateuszjasiuk mateuszjasiuk force-pushed the chore/update-namada-to-0.21.0 branch 2 times, most recently from 77cab9a to 54f5bae Compare August 8, 2023 11:51
@mateuszjasiuk mateuszjasiuk changed the title WIP: chore: update namada to 0.21.0 WIP: chore: update namada to multisig changes(0.21.0) Aug 8, 2023
@github-actions github-actions bot temporarily deployed to pull request August 8, 2023 12:08 Inactive
@jurevans jurevans self-requested a review August 15, 2023 11:58
@jurevans jurevans self-assigned this Aug 15, 2023
@jurevans jurevans force-pushed the chore/update-namada-to-0.21.0 branch from 6c88b3b to e4852b6 Compare August 15, 2023 12:09
@github-actions github-actions bot temporarily deployed to pull request August 15, 2023 12:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 17, 2023 15:21 Inactive
@jurevans jurevans mentioned this pull request Aug 18, 2023
Closed
12 tasks
@jurevans jurevans force-pushed the chore/update-namada-to-0.21.0 branch from 9627b0f to f23e2f9 Compare August 22, 2023 09:26
@github-actions github-actions bot temporarily deployed to pull request August 22, 2023 09:32 Inactive
jurevans
jurevans approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@jurevans jurevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will merge once fix is in the release.

@github-actions github-actions bot temporarily deployed to pull request August 30, 2023 11:48 Inactive
@mateuszjasiuk mateuszjasiuk changed the title WIP: chore: update namada to multisig changes(0.21.0) WIP: chore: update namada to draft/0.22 Aug 31, 2023
@github-actions github-actions bot temporarily deployed to pull request September 4, 2023 09:42 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 5, 2023 12:33 Inactive
jurevans
jurevans reviewed Sep 5, 2023
View reviewed changes
packages/shared/lib/src/sdk/mod.rs Outdated

let address = Address::from(pk);

//TODO: add cehck for faucet
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this comment

@mateuszjasiuk mateuszjasiuk marked this pull request as ready for review September 7, 2023 07:57
@github-actions github-actions bot temporarily deployed to pull request September 7, 2023 08:04 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 7, 2023 09:11 Inactive
jurevans
jurevans approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@jurevans jurevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jurevans jurevans changed the title WIP: chore: update namada to draft/0.22 chore: update namada to draft/0.22 Sep 7, 2023
@mateuszjasiuk mateuszjasiuk merged commit 8750cda into main Sep 7, 2023
6 checks passed
@mateuszjasiuk mateuszjasiuk deleted the chore/update-namada-to-0.21.0 branch September 13, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurevans jurevans jurevans approved these changes

@emccorson emccorson Awaiting requested review from emccorson

Assignees

@jurevans jurevans

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateuszjasiuk @jurevans