Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up staking #315

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Fix up staking #315

merged 1 commit into from
Jul 25, 2023

Conversation

emccorson
Copy link
Collaborator

@emccorson emccorson commented Jun 23, 2023

  • refactor(StakingOverview): Split into separate components

  • fix: Display some unfetched amounts as "-" instead of "NAM 0"

  • fix: Use more redux selectors instead of passing props

  • feat(StakingBalancesList): Display total unbonded and withdrawable amounts

  • feat(MyValidatorsTable): Display unbonded and withdrawable amounts

  • feat(AllValidatorsTable): Add filtering by search and sorting by column

  • feat(ValidatorDetails): Add UI to withdraw unbonded tokens

  • feat(ValidatorDetails): Display each bond and unbond individually

  • fix(ValidatorDetails): Display http URLs as links

  • fix(UnbondPosition): Make stakedAmount BigNumber instead of number

  • fix(StakingAndGovernance/types): Make ChangeInStakingPosition amount always positive (negative does not represent unbond)

  • fix(StakingAndGovernance/types): Make more types optional; for when data is unfetched

  • fix(StakingAndGovernance/types): Make some amounts BigNumbers; for use in calculations

  • fix(StakingAndGovernance/actions): Make voting power 1:1 with staked amount in namnam

  • fix(Modal): Apply app theme to modals

  • feat(Table): Add subheading slot; for elements between table and heading

  • feat(Table): Add onClick prop; called when a column heading is clicked

  • fix(shared): Send bond amount in NAM

@github-actions
Copy link

github-actions bot commented Jun 23, 2023

@github-actions github-actions bot temporarily deployed to pull request June 23, 2023 03:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 23, 2023 04:05 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 23, 2023 04:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 23, 2023 06:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 23, 2023 07:17 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 26, 2023 01:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 26, 2023 04:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 28, 2023 01:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 28, 2023 01:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 28, 2023 03:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 28, 2023 03:35 Inactive
emccorson added a commit that referenced this pull request Jul 3, 2023
Merging to test out namada v0.17.5 on staking fixup branch (#315).
@github-actions github-actions bot temporarily deployed to pull request July 3, 2023 02:05 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 5, 2023 00:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 5, 2023 01:03 Inactive
@emccorson emccorson force-pushed the feat/staking-fixup branch 2 times, most recently from 39502ed to b4e8a69 Compare July 10, 2023 06:43
@github-actions github-actions bot temporarily deployed to pull request July 10, 2023 06:54 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 10, 2023 07:45 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 11, 2023 00:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 19, 2023 00:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 21, 2023 04:08 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 21, 2023 05:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 21, 2023 07:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2023 01:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2023 03:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2023 03:54 Inactive
@emccorson emccorson marked this pull request as ready for review July 24, 2023 09:53
Copy link
Collaborator

@mateuszjasiuk mateuszjasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works nice! Left couple of minor comments!

Copy link
Collaborator

@jurevans jurevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@emccorson emccorson force-pushed the feat/staking-fixup branch 2 times, most recently from e254d73 to 2366fe4 Compare July 25, 2023 02:17
@github-actions github-actions bot temporarily deployed to pull request July 25, 2023 02:30 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 25, 2023 07:52 Inactive
  - refactor(StakingOverview): Split into separate components

  - fix: Display some unfetched amounts as "-" instead of "NAM 0"

  - fix: Use more redux selectors instead of passing props

  - feat(StakingBalancesList): Display total unbonded and withdrawable
    amounts

  - feat(MyValidatorsTable): Display unbonded and withdrawable amounts

  - feat(AllValidatorsTable): Add filtering by search and sorting by
    column

  - feat(ValidatorDetails): Add UI to withdraw unbonded tokens

  - feat(ValidatorDetails): Display each bond and unbond individually

  - fix(ValidatorDetails): Display http URLs as links

  - fix(UnbondPosition): Make stakedAmount BigNumber instead of number

  - fix(StakingAndGovernance/types): Make ChangeInStakingPosition amount
    always positive (negative does not represent unbond)

  - fix(StakingAndGovernance/types): Make more types optional; for when
    data is unfetched

  - fix(StakingAndGovernance/types): Make some amounts BigNumbers; for
    use in calculations

  - fix(StakingAndGovernance/actions): Make voting power 1:1 with staked
    amount in namnam

  - fix(Modal): Apply app theme to modals

  - feat(Table): Add subheading slot; for elements between table and
    heading

  - feat(Table): Add onClick prop; called when a column heading is
    clicked

  - fix(shared): Send bond amount in NAM
@emccorson emccorson merged commit f706dd3 into main Jul 25, 2023
2 checks passed
@github-actions github-actions bot temporarily deployed to pull request July 25, 2023 08:25 Inactive
@mateuszjasiuk mateuszjasiuk deleted the feat/staking-fixup branch September 13, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants