-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up staking #315
Merged
Merged
Fix up staking #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emccorson
force-pushed
the
feat/staking-fixup
branch
from
June 23, 2023 04:08
4b2fa45
to
c80b63e
Compare
emccorson
force-pushed
the
feat/staking-fixup
branch
from
June 23, 2023 06:20
c80b63e
to
4829d25
Compare
emccorson
force-pushed
the
feat/staking-fixup
branch
from
June 26, 2023 00:59
dc4ec01
to
506f70a
Compare
emccorson
force-pushed
the
feat/staking-fixup
branch
from
June 28, 2023 02:58
635e1fc
to
ecd12e6
Compare
emccorson
added a commit
that referenced
this pull request
Jul 3, 2023
Merging to test out namada v0.17.5 on staking fixup branch (#315).
emccorson
force-pushed
the
feat/staking-fixup
branch
from
July 3, 2023 01:52
e4d3589
to
eec0fca
Compare
emccorson
force-pushed
the
feat/staking-fixup
branch
from
July 5, 2023 00:14
eec0fca
to
7701fe2
Compare
emccorson
force-pushed
the
feat/staking-fixup
branch
from
July 5, 2023 00:52
7701fe2
to
cff0c5b
Compare
emccorson
force-pushed
the
feat/staking-fixup
branch
2 times, most recently
from
July 10, 2023 06:43
39502ed
to
b4e8a69
Compare
emccorson
force-pushed
the
feat/staking-fixup
branch
from
July 11, 2023 00:39
d8944e8
to
82b242b
Compare
emccorson
force-pushed
the
feat/staking-fixup
branch
from
July 13, 2023 11:43
82b242b
to
a8af172
Compare
emccorson
force-pushed
the
feat/staking-fixup
branch
from
July 19, 2023 00:09
17d9695
to
b477dfe
Compare
emccorson
force-pushed
the
feat/staking-fixup
branch
from
July 21, 2023 03:55
b477dfe
to
0b38ff5
Compare
emccorson
force-pushed
the
feat/staking-fixup
branch
from
July 21, 2023 06:46
c7588ae
to
597df8c
Compare
emccorson
force-pushed
the
feat/staking-fixup
branch
from
July 24, 2023 01:20
597df8c
to
d306ae2
Compare
emccorson
force-pushed
the
feat/staking-fixup
branch
from
July 24, 2023 02:42
a6ca9a0
to
f4fe944
Compare
emccorson
force-pushed
the
feat/staking-fixup
branch
from
July 24, 2023 03:40
256d618
to
42d3665
Compare
mateuszjasiuk
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works nice! Left couple of minor comments!
apps/namada-interface/src/App/Staking/StakingOverview/AllValidatorsTable/AllValidatorsTable.tsx
Show resolved
Hide resolved
apps/namada-interface/src/App/Staking/StakingOverview/AllValidatorsTable/AllValidatorsTable.tsx
Outdated
Show resolved
Hide resolved
apps/namada-interface/src/App/Staking/StakingOverview/AllValidatorsTable/AllValidatorsTable.tsx
Show resolved
Hide resolved
apps/namada-interface/src/App/Staking/StakingOverview/AllValidatorsTable/AllValidatorsTable.tsx
Show resolved
Hide resolved
apps/namada-interface/src/App/Staking/StakingOverview/AllValidatorsTable/AllValidatorsTable.tsx
Outdated
Show resolved
Hide resolved
jurevans
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM
emccorson
force-pushed
the
feat/staking-fixup
branch
2 times, most recently
from
July 25, 2023 02:17
e254d73
to
2366fe4
Compare
emccorson
force-pushed
the
feat/staking-fixup
branch
from
July 25, 2023 07:38
88bc142
to
5a47213
Compare
mateuszjasiuk
approved these changes
Jul 25, 2023
- refactor(StakingOverview): Split into separate components - fix: Display some unfetched amounts as "-" instead of "NAM 0" - fix: Use more redux selectors instead of passing props - feat(StakingBalancesList): Display total unbonded and withdrawable amounts - feat(MyValidatorsTable): Display unbonded and withdrawable amounts - feat(AllValidatorsTable): Add filtering by search and sorting by column - feat(ValidatorDetails): Add UI to withdraw unbonded tokens - feat(ValidatorDetails): Display each bond and unbond individually - fix(ValidatorDetails): Display http URLs as links - fix(UnbondPosition): Make stakedAmount BigNumber instead of number - fix(StakingAndGovernance/types): Make ChangeInStakingPosition amount always positive (negative does not represent unbond) - fix(StakingAndGovernance/types): Make more types optional; for when data is unfetched - fix(StakingAndGovernance/types): Make some amounts BigNumbers; for use in calculations - fix(StakingAndGovernance/actions): Make voting power 1:1 with staked amount in namnam - fix(Modal): Apply app theme to modals - feat(Table): Add subheading slot; for elements between table and heading - feat(Table): Add onClick prop; called when a column heading is clicked - fix(shared): Send bond amount in NAM
emccorson
force-pushed
the
feat/staking-fixup
branch
from
July 25, 2023 08:11
5a47213
to
f706dd3
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(StakingOverview): Split into separate components
fix: Display some unfetched amounts as "-" instead of "NAM 0"
fix: Use more redux selectors instead of passing props
feat(StakingBalancesList): Display total unbonded and withdrawable amounts
feat(MyValidatorsTable): Display unbonded and withdrawable amounts
feat(AllValidatorsTable): Add filtering by search and sorting by column
feat(ValidatorDetails): Add UI to withdraw unbonded tokens
feat(ValidatorDetails): Display each bond and unbond individually
fix(ValidatorDetails): Display http URLs as links
fix(UnbondPosition): Make stakedAmount BigNumber instead of number
fix(StakingAndGovernance/types): Make ChangeInStakingPosition amount always positive (negative does not represent unbond)
fix(StakingAndGovernance/types): Make more types optional; for when data is unfetched
fix(StakingAndGovernance/types): Make some amounts BigNumbers; for use in calculations
fix(StakingAndGovernance/actions): Make voting power 1:1 with staked amount in namnam
fix(Modal): Apply app theme to modals
feat(Table): Add subheading slot; for elements between table and heading
feat(Table): Add onClick prop; called when a column heading is clicked
fix(shared): Send bond amount in NAM