-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add disconnect account approval step #1101
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4ef4d3f
feat: rename SwitchAccountPanel
euharrison eea10c9
feat: anchor panel top right
euharrison cf7479f
feat: add approval step to disconnect
euharrison 4754eb2
feat: add new message when disconnect is approved
euharrison 5a86087
feat: create common function openPopup
euharrison 6aee9ef
feat: create common function getResolver
euharrison a331d4b
feat: remove resolvers from closed tabs
euharrison 0c8c2e2
feat: improve tests
euharrison 6951451
feat: use route to launch popup
euharrison 5a9e175
feat: rename popup
euharrison 66d5903
feat: add more test
euharrison b3d34be
feat: add removeResolver
euharrison 8cc08e8
feat: fix test
euharrison 3295408
feat: clean
euharrison File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
import { ActionButton, Alert, GapPatterns, Stack } from "@namada/components"; | ||
import { PageHeader } from "App/Common"; | ||
import { DisconnectInterfaceResponseMsg } from "background/approvals"; | ||
import { useQuery } from "hooks"; | ||
import { useRequester } from "hooks/useRequester"; | ||
import { Ports } from "router"; | ||
import { closeCurrentTab } from "utils"; | ||
|
||
export const ApproveDisconnection: React.FC = () => { | ||
const requester = useRequester(); | ||
const params = useQuery(); | ||
const interfaceOrigin = params.get("interfaceOrigin"); | ||
|
||
const handleResponse = async (revokeConnection: boolean): Promise<void> => { | ||
if (interfaceOrigin) { | ||
await requester.sendMessage( | ||
Ports.Background, | ||
new DisconnectInterfaceResponseMsg(interfaceOrigin, revokeConnection) | ||
); | ||
await closeCurrentTab(); | ||
} | ||
}; | ||
|
||
return ( | ||
<Stack full gap={GapPatterns.TitleContent} className="pt-4 pb-8"> | ||
<PageHeader title="Approve Request" /> | ||
<Stack full className="justify-between" gap={12}> | ||
<Alert type="warning"> | ||
Approve disconnect for <strong>{interfaceOrigin}</strong>? | ||
</Alert> | ||
<Stack gap={2}> | ||
<ActionButton onClick={() => handleResponse(true)}> | ||
Approve | ||
</ActionButton> | ||
<ActionButton | ||
outlineColor="yellow" | ||
onClick={() => handleResponse(false)} | ||
> | ||
Reject | ||
</ActionButton> | ||
</Stack> | ||
</Stack> | ||
</Stack> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interfaceTabId
wasn't used anymore, it was replaced bypopupTabId
directly on the service