Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/1098 - SDK: Add remaining Transfer types #1099

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

jurevans
Copy link
Collaborator

@jurevans jurevans commented Sep 12, 2024

Resolves #1098

Mainly we want to add support to MASP to the SDK & the Interface. Short of implementing the Transfer UI, we should have the following:

Need args and Borsh schema for:

  • Shielded Transfer (Shielded<->Shielded)
  • Shielding Transfer (Transparent->Shielded)
  • Unshielding Transfer (Shielding->Shielded)

Need SDK (@heliax/namada-sdk) functions for:

  • build_shielded_transfer
  • build_shielding_transfer
  • build_unshielding_transfer

Docs:

  • Regenerate docs for @namada/types @heliax/namada-sdk

TODO:

  • Load MASP Params into SDK wasm (fetch & store, provide to SDK)

@jurevans jurevans self-assigned this Sep 12, 2024
@jurevans jurevans force-pushed the feat/1098-add-remaining-transfer-types branch 9 times, most recently from 3e77943 to fed376f Compare September 12, 2024 16:36
@jurevans jurevans changed the title WIP: feat/1098 - SDK: Add remaining Transfer types feat/1098 - SDK: Add remaining Transfer types Sep 12, 2024
@jurevans jurevans marked this pull request as ready for review September 12, 2024 17:16
@jurevans jurevans force-pushed the feat/1098-add-remaining-transfer-types branch from dc6003a to 8cfa4f4 Compare September 13, 2024 11:18
Copy link
Contributor

@pedrorezende pedrorezende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typescript part LGTM! Let's wait for @mateuszjasiuk or @emccorson review for Rust part :)

Copy link
Collaborator

@mateuszjasiuk mateuszjasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@jurevans jurevans merged commit 2f9da91 into main Sep 17, 2024
8 checks passed
@jurevans jurevans deleted the feat/1098-add-remaining-transfer-types branch September 17, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK package: Hook up remaining Transfer types
3 participants