Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/1055 - Faucet settings #1056

Merged
merged 4 commits into from
Sep 3, 2024
Merged

feat/1055 - Faucet settings #1056

merged 4 commits into from
Sep 3, 2024

Conversation

jurevans
Copy link
Collaborator

@jurevans jurevans commented Aug 29, 2024

Resolves #1055

  • Added settings modal to configure Faucet API url with basic persistence (localStorage)
  • Restructured a bit
  • Faucet Limit is now determined by settings (from API)
  • Updated components so that forms submit on Enter key

Testing

  • Build and load the faucet app as per usual, in the top right, click the gear icon
  • Enter a new valid URL, then submit
  • If this new URL cannot load settings, you will see an error. Setting this to a valid API url will reload the settings and clear the error
  • Reload page to ensure this was persisted, or check the local storage key for baseUrl

@jurevans jurevans self-assigned this Aug 29, 2024
@jurevans jurevans changed the title WIP: feat/1055 - Faucet settings feat/1055 - Faucet settings Aug 30, 2024
@jurevans jurevans requested review from pedrorezende, mateuszjasiuk, emccorson and euharrison and removed request for pedrorezende August 30, 2024 14:01
@jurevans jurevans marked this pull request as ready for review August 30, 2024 14:01
Copy link
Collaborator

@mateuszjasiuk mateuszjasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Tested and it works for me :)

@jurevans jurevans merged commit 9d8711e into main Sep 3, 2024
8 checks passed
@jurevans jurevans deleted the feat/1055-faucet-settings branch September 3, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faucet app: Discuss/Implement configurable API settings
2 participants