fix: fix fees and redelegating to same validator #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emccorson
force-pushed
the
975-transaction-fee
branch
3 times, most recently
from
6ec9fa7
to
61735d1
Compare
emccorson
requested review from
jurevans,
euharrison,
pedrorezende and
mateuszjasiuk
- Add default gas config and use it to display correct transaction fees - Disallow redelegating when it would result in no transactions (e.g. redelegating to the same validator) - Refactor redelegate validation and display clearer error message in submit button Fixes #975.
emccorson
force-pushed
the
975-transaction-fee
branch
from
61735d1
to
4f090ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add default gas config and use it to display correct transaction fees
Disallow redelegating when it would result in no transactions (e.g. redelegating to the same validator)
Refactor redelegate validation and display clearer error message in submit button
Fixes #975.