Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension - address feedback #1016

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Extension - address feedback #1016

merged 2 commits into from
Aug 21, 2024

Conversation

jurevans
Copy link
Collaborator

@jurevans jurevans commented Aug 20, 2024

Resolves #1015

  • Namadillo should use chain ID from indexer only
  • Lengthen "shortened" address in set up (Key import) - Note: I updated the component to accept a trim value for shortenAddress(), otherwise it will default to 16, and tried to find values in Setup and View Keys that would work well with different keys through trial and error. It should be close, but I imagine with some keys it may be possible that part of a character clips, if so, we can reduce the trim in that case.

Screenshots

Lengthen keys in Setup view:
Screen Shot 2024-08-20 at 11 30 47 AM

Lengthen keys in View Keys view:
Screen Shot 2024-08-20 at 11 32 59 AM

@jurevans jurevans added this to the PoS, Governance milestone Aug 20, 2024
@jurevans jurevans self-assigned this Aug 20, 2024
@jurevans jurevans force-pushed the feat/1015-extension-feedback branch from 9241576 to cdb7727 Compare August 20, 2024 15:24
@jurevans jurevans changed the title WIP: Extension - address feedback Extension - address feedback Aug 20, 2024
@jurevans jurevans marked this pull request as ready for review August 20, 2024 16:17
@euharrison
Copy link
Contributor

@jurevans my impression was that we should increase the box width to fit the whole text without the ellipsis, no?

@jurevans
Copy link
Collaborator Author

@jurevans my impression was that we should increase the box width to fit the whole text without the ellipsis, no?

@euharrison I believe we were to use as much of the space so we can to see more of the address. It was configured to work in the View Keys view, which left a lot of blank space when that same setting was used in Setup

@jurevans jurevans force-pushed the feat/1015-extension-feedback branch from 9d67b1d to ccd1598 Compare August 20, 2024 18:49
@jurevans jurevans merged commit d7d0a78 into main Aug 21, 2024
8 checks passed
@jurevans jurevans deleted the feat/1015-extension-feedback branch August 21, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension: UX/UI changes per feedback
2 participants