-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.40.0] Update SDK v0.39.0 -> v0.40.0 #80
Conversation
fd4b8ee
to
3332dd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joel-u410 Thanks! Tested and it looks great. I would not rename TransparentTransfer
to Transfer
as it's closer to what we have in the namada sdk atm
As a side note, if you plan to contribute in the future, you do not have to care about breaking changes to migrations(or any other breaking change) up the the point of first release.
@sirouk Thanks again for your contribution. I will close #69 in favor of this one, as it's almost done.
Ok, no problem, I can rename it back. Should I also revert the enum change in the schema migrations? |
@mateuszjasiuk see the latest commit -- is this what you had in mind? |
Yup! This is great. Thank you :) |
Ah run |
Head branch was pushed to by a user without write access
Ah yes, forgot about |
Including: * Update for 0.40.0 compatibility * Implement serialization for Transfer * Rename transparent_transfer -> transfer
87a60c3
to
45240a3
Compare
And just rebased to latest |
Including the following changes:
This is roughly similar to #69 but with a couple notable differences:
Transfer
based on @mateuszjasiuk's implementation but slightly changed (see below)transparent_transfer
enum value is renamed totransfer
in the schemaSerialization example for
Transfer
(formatted for readability):I changed the
BTreeMap<Account, DenominatedAmount>
to a list of{ amount, token, owner }
objects instead of a map with the account as key -- in my opinion, it will be easier for consumers to parse the data that way. Thoughts?