Add support for anoma specific functions to the Core evaluator #2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcadman
added
anoma
core
paulcadman
force-pushed
the
anoma-core-eval
branch
3 times, most recently
from
01f96bf
to
6fe2d9d
Compare
lukaszcz
force-pushed
the
anoma-core-eval
branch
from
6fe2d9d
to
1a53e88
Compare
lukaszcz
reviewed
Jun 24, 2024
lukaszcz
reviewed
Jun 24, 2024
lukaszcz
reviewed
Jun 24, 2024
paulcadman
force-pushed
the
anoma-core-eval
branch
from
5c83d25
to
c4d6987
Compare
These encode/decode a ByteString to/from its little endian integer representation. The length of the ByteString is encoded at the beginning of the encoded output so that rountripping works correctly.
We need to serialize Closure Nodes in the Core evaluator, only for use with Anoma encode/decode functions.
We can use `Core.Extra.Utils.removeClosures` to remove the Closure nodes from the Core.Node before transforming to Store.Core.Node
paulcadman
force-pushed
the
anoma-core-eval
branch
from
c4d6987
to
67ff897
Compare
lukaszcz
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
anoma{encode, decode, sign, verify, signDetached, verifyDetached}functions to the Core evaluator.Encoding / Decoding
The serialization of values to
ByteStringforanomaEncodereuses the Stored Core serialization.Anoma expects encoding of bytes as little-endian integers. In general
ByteString -> Integeris ambiguous because twoByteStrings that differ only by zero padding will map to the same integer. So we must encode the length of the ByteString in the encoded integer alongside the ByteString data so when it is decoded we can pad appropriately. We use the same length encoding scheme that is used by Nockma jam.Verify
The Core evaluator implementation of
anomaVerifycrashes if the verification fails. This matches the behaviour of Anoma node.jvcSupportYou can now use
anoma-*functions within.jvccore files.