Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parallel template #2809

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Improve parallel template #2809

merged 1 commit into from
Jun 7, 2024

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Jun 6, 2024

Now we properly wait for the log and worker threads to finish instead of keeping them alive until the main thread dies.

Also, because we are now using replicateConcurrently_ from async, any exception in a worker thread should be properly propagated.

@janmasrovira janmasrovira self-assigned this Jun 6, 2024
@janmasrovira janmasrovira marked this pull request as ready for review June 6, 2024 17:25
@lukaszcz lukaszcz merged commit a2c1a4a into main Jun 7, 2024
4 checks passed
@lukaszcz lukaszcz deleted the async branch June 7, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace low level forkIO with a safer alternative
2 participants