Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cairo field compatibility #2712

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Cairo field compatibility #2712

merged 3 commits into from
Apr 9, 2024

Conversation

lukaszcz
Copy link
Collaborator

@lukaszcz lukaszcz commented Apr 8, 2024 •
edited
Loading

This PR implements changes to make the eval command and internal development commands fully Cairo-compatible.

  • Change the default field size to Cairo field size
  • Change the printing of "negative" field elements to be compatible with the Cairo VM
  • Quote function names in the Reg to CASM translation

@lukaszcz lukaszcz added the cairo label Apr 8, 2024
@lukaszcz lukaszcz added this to the 0.6.2 milestone Apr 8, 2024
@lukaszcz lukaszcz self-assigned this Apr 8, 2024
@lukaszcz lukaszcz marked this pull request as ready for review April 8, 2024 16:52
@lukaszcz lukaszcz merged commit 279db70 into main Apr 9, 2024
5 of 8 checks passed
@lukaszcz lukaszcz deleted the cairo-field branch April 9, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janmasrovira janmasrovira janmasrovira approved these changes

@paulcadman paulcadman Awaiting requested review from paulcadman

Assignees

@lukaszcz lukaszcz

Labels
cairo
Projects
None yet
Milestone
0.6.2
Development

Successfully merging this pull request may close these issues.
2 participants
@lukaszcz @janmasrovira