Update REPL artifacts with builtins from stored modules #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcadman
force-pushed
the
fix-repl-builtins
branch
2 times, most recently
from
51187dd
to
a2cede1
Compare
paulcadman
force-pushed
the
fix-repl-builtins
branch
from
79afa51
to
7227fff
Compare
janmasrovira
previously approved these changes
Feb 26, 2024
paulcadman
force-pushed
the
fix-repl-builtins
branch
2 times, most recently
from
6724e4e
to
6d7ecb4
Compare
janmasrovira
approved these changes
Feb 26, 2024
paulcadman
force-pushed
the
fix-repl-builtins
branch
from
6d7ecb4
to
0b74b0b
Compare
paulcadman
force-pushed
the
fix-repl-builtins
branch
from
0b74b0b
to
c4fcd15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builtin information needs to be propagated from stored modules to REPL artifacts to avoid "The builtin _ has not been defined" errors.
This PR adds a test suite for the REPL in the Haskell test code. This means some of the slow smoke tests can be moved to fast haskell unit tests. In future we should refactor the REPL code by putting in the main src target and unit testing more features (e.g :doc, :def).