Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show import with public keyword in the html doc #2456

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Show import with public keyword in the html doc #2456

merged 1 commit into from
Oct 23, 2023

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira self-assigned this Oct 20, 2023
@janmasrovira janmasrovira marked this pull request as ready for review October 20, 2023 08:45
@jonaprieto
Copy link
Collaborator

Let's add one smoke test as in here:

juvix/tests/smoke/Commands/html.smoke.yaml

Lines 17 to 28 in 4dd80e7

- name: html-stdout
command:
shell:
- bash
script: |
cd milestone/HelloWorld
juvix html HelloWorld.juvix --only-source
cat html/HelloWorld.html
stdout:
contains:
<!DOCTYPE HTML>
exit-status: 0

Instead of checking for <!DOCTYPE HTML>, put something sensible related to this fix.

@jonaprieto jonaprieto self-requested a review October 20, 2023 10:14
@jonaprieto jonaprieto force-pushed the fix-html-public-import branch 3 times, most recently from dabb775 to bfa41e2 Compare October 23, 2023 13:07
@jonaprieto jonaprieto merged commit f58c4a6 into main Oct 23, 2023
4 checks passed
@jonaprieto jonaprieto deleted the fix-html-public-import branch October 23, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaprieto jonaprieto jonaprieto approved these changes

Assignees

@janmasrovira janmasrovira

Labels
fix:bug html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Public imports not showing in html documentation
2 participants
@janmasrovira @jonaprieto