Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid the -Os option when generating WebAssembly #2378

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Avoid the -Os option when generating WebAssembly #2378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions app/Commands/Extra/Compile.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,32 +170,36 @@ commonArgs buildDir o outfile =
| otherwise -> []
)

optimizationOption :: CompileOptions -> String
optimizationOption o =
"-O" <> show (maybe defaultOptLevel (max 1) (o ^. compileOptimizationLevel))
where
defaultOptLevel :: Int
defaultOptLevel
| o ^. compileDebug = debugClangOptimizationLevel
| otherwise = defaultClangOptimizationLevel

native64Args :: Path Abs Dir -> CompileOptions -> Path Abs File -> Path Abs File -> [String]
native64Args buildDir o outfile inputFile =
commonArgs buildDir o outfile
<> [ "-DARCH_NATIVE64",
"-DAPI_LIBC",
"-m64",
"-O" <> show (maybe defaultOptLevel (max 1) (o ^. compileOptimizationLevel)),
optimizationOption o,
toFilePath inputFile
]
<> ( if
| not (o ^. compilePreprocess || o ^. compileAssembly) ->
["-ljuvix"]
| otherwise -> []
)
where
defaultOptLevel :: Int
defaultOptLevel
| o ^. compileDebug = debugClangOptimizationLevel
| otherwise = defaultClangOptimizationLevel

wasiArgs :: Path Abs Dir -> CompileOptions -> Path Abs File -> Path Abs File -> Path Abs Dir -> [String]
wasiArgs buildDir o outfile inputFile sysrootPath =
commonArgs buildDir o outfile
<> [ "-DARCH_WASM32",
"-DAPI_WASI",
"-Os",
optimizationOption o,
"-nodefaultlibs",
"--target=wasm32-wasi",
"--sysroot",
Expand Down