Small refactor for traits #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
force-pushed
the
trait-framework-jan
branch
from
5878b8e
to
f97806a
Compare
lukaszcz
force-pushed
the
trait-framework-jan
branch
from
f97806a
to
6ca9c0d
Compare
janmasrovira
force-pushed
the
trait-framework-jan
branch
from
6ca9c0d
to
ac4fa89
Compare
lukaszcz
force-pushed
the
trait-framework
branch
2 times, most recently
from
ced6c7c
to
34d35f1
Compare
janmasrovira
force-pushed
the
trait-framework-jan
branch
from
ac4fa89
to
e3e13b9
Compare
janmasrovira
force-pushed
the
trait-framework-jan
branch
from
e3e13b9
to
5a49a94
Compare
lukaszcz
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr simplifies parsing by removing
FunctionParameterUnnamed. It also removes ghost wildcards introduced during parsing.It also introduces an error for double braced atoms
{{x}}that are not on the left of an arrow->