Improve iterator and named arguments parsing #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszcz
changed the title
lukaszcz
changed the title
lukaszcz
force-pushed
the
iterator-parsing
branch
from
859f8b2
to
fe11dc6
Compare
lukaszcz
force-pushed
the
iterator-parsing
branch
from
fe11dc6
to
5b02d50
Compare
jonaprieto
reviewed
Aug 11, 2023
jonaprieto
force-pushed
the
iterator-parsing
branch
from
5b02d50
to
4fae98a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid excessive backtracking in iterator and named arguments parsing. This also improves error messages by committing to a parsing branch as early as possible.