Store source location of (almost) everything #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
force-pushed
the
2162-store-source-location-of-everything
branch
3 times, most recently
from
994a179
to
40b64c8
Compare
janmasrovira
force-pushed
the
2162-store-source-location-of-everything
branch
from
2a5fc33
to
c7abcbd
Compare
jonaprieto
previously approved these changes
Jun 7, 2023
jonaprieto
force-pushed
the
2162-store-source-location-of-everything
branch
from
c12f037
to
e4abd53
Compare
jonaprieto
force-pushed
the
2162-store-source-location-of-everything
branch
from
e4abd53
to
dacac48
Compare
jonaprieto
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr improves formatting of source files with comments.
The concrete ast now stores location information of almost all keywords.
We do not store location information of parentheses. Comments will be pushed out of parentheses by the formatter.
E.g.
will become
This only occurs if the comment appears just after the
(. So the following will be respected