Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new import ... open syntax in REPL #2156

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Conversation

paulcadman
Copy link
Collaborator

@paulcadman paulcadman commented May 31, 2023

Similar to #2098 which introduced the new import ... open syntax the old syntax is still supported.

The try must be removed when the old open import ... syntax is removed.

@paulcadman paulcadman added this to the 0.3.5 milestone May 31, 2023
@paulcadman paulcadman self-assigned this May 31, 2023
@jonaprieto jonaprieto self-requested a review June 1, 2023 08:10
Similar to #2098 which introducted
the new `import ... open` syntax the old syntax is still supported.

The `try` must be removed when the old `open import ...` syntax is
removed.
Copy link
Collaborator

@jonaprieto jonaprieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested also locally, well done.

@jonaprieto jonaprieto merged commit 7e1a641 into main Jun 1, 2023
@jonaprieto jonaprieto deleted the new-import-open-repl branch June 1, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import ... open syntax does not work in REPL
3 participants