Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope check symbols inside using {..} and hiding {..} #2108

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented May 19, 2023

Now the symbols inside using {..} and hiding {..} are properly scoped, which means that they will be properly colored and will have goto information. If the referenced module does not contain a symbol in the list, an error will be thrown.

@janmasrovira janmasrovira added this to the 0.3.4 milestone May 19, 2023
@janmasrovira janmasrovira self-assigned this May 19, 2023
@janmasrovira janmasrovira changed the title Scope check symbols inside using {..} Scope check symbols inside using {..} and hiding {..} May 19, 2023
@janmasrovira janmasrovira added the enhancement New feature or request label May 19, 2023
@janmasrovira janmasrovira marked this pull request as ready for review May 20, 2023 07:15
@jonaprieto
Copy link
Collaborator

Tested locally. +1

@jonaprieto jonaprieto merged commit ab83749 into main May 22, 2023
@jonaprieto jonaprieto deleted the 2089-enhance-def-location-output-to-also-provide-location-for-symbols-in-usinghiding-list branch May 22, 2023 09:41
jonaprieto pushed a commit that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scoping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Def. Location Output to Also Provide Location for Symbols in using/hiding List
2 participants