Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more paths #2000

Merged
merged 19 commits into from
Apr 19, 2023
Merged

Support more paths #2000

merged 19 commits into from
Apr 19, 2023

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Apr 13, 2023 •
edited
Loading

This pr makes it possible to use ~, .. and environment variables in the juvix.yaml and all flags / input of the cli.

In the CLI, the shell will be responsible for replacing environment variables with their value, so the usual syntax can be used. For the dependencies field, I have implemented a parser that has some restrictions:

  1. Environment variables are given with the makefile-like syntax $(VAR)
  2. The three characters $ ( ) are reserved for the environment variables syntax.
    They cannot be part of the path.
  3. ~ is reserved for $(HOME). I.e. the prepath ~~ will expand to $HOME$HOME.
  4. Nested environment variables are not allowed.

Thanks @paulcadman for the feedback. I think we are ready to merge this nightmarish pr 👻

@janmasrovira janmasrovira added enhancement New feature or request CLI labels Apr 13, 2023
@janmasrovira janmasrovira self-assigned this Apr 13, 2023
@janmasrovira janmasrovira added this to the 0.3.2 milestone Apr 13, 2023
@janmasrovira janmasrovira temporarily deployed to github-pages April 13, 2023 17:19 — with GitHub Actions Inactive
@janmasrovira janmasrovira temporarily deployed to github-pages April 13, 2023 18:10 — with GitHub Actions Inactive
@janmasrovira janmasrovira temporarily deployed to github-pages April 14, 2023 11:07 — with GitHub Actions Inactive
@janmasrovira janmasrovira temporarily deployed to github-pages April 18, 2023 11:50 — with GitHub Actions Inactive
@jonaprieto jonaprieto modified the milestones: 0.3.2 - HB-J, 0.3.3 Apr 18, 2023
@janmasrovira janmasrovira temporarily deployed to github-pages April 18, 2023 13:27 — with GitHub Actions Inactive
@janmasrovira janmasrovira marked this pull request as ready for review April 18, 2023 16:17
@janmasrovira janmasrovira temporarily deployed to github-pages April 18, 2023 16:28 — with GitHub Actions Inactive
@paulcadman paulcadman temporarily deployed to github-pages April 18, 2023 17:15 — with GitHub Actions Inactive
@janmasrovira janmasrovira temporarily deployed to github-pages April 19, 2023 14:24 — with GitHub Actions Inactive
paulcadman
paulcadman approved these changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@paulcadman paulcadman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I can now sleep soundly 🕊️

@paulcadman paulcadman temporarily deployed to github-pages April 19, 2023 14:39 — with GitHub Actions Inactive
@paulcadman paulcadman merged commit 3d012cc into main Apr 19, 2023
@paulcadman paulcadman deleted the support-more-paths branch April 19, 2023 14:56
@janmasrovira janmasrovira mentioned this pull request Apr 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcadman paulcadman paulcadman approved these changes

Assignees

@janmasrovira janmasrovira

Labels
CLI enhancement New feature or request
Projects
None yet
Milestone
0.3.3
Development

Successfully merging this pull request may close these issues.

Allow .. and ~ in paths given in flags and in juvix.yaml
3 participants
@janmasrovira @paulcadman @jonaprieto