Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix juvix init #1835

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Fix juvix init #1835

merged 2 commits into from
Feb 10, 2023

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Feb 10, 2023 •
edited
Loading

My guess is that the behaviour of aeson changed at some point.
Before, providing toEncoding was working as expected. Now I needed to implement toJSON as well.

@janmasrovira janmasrovira self-assigned this Feb 10, 2023
@janmasrovira janmasrovira linked an issue Feb 10, 2023 that may be closed by this pull request
juvix init generates an invalid Juvix package file #1831
Closed
@janmasrovira janmasrovira force-pushed the juvix-init-generates-an-invalid-juvix-package-file branch from 9286a83 to 7af29d7 Compare February 10, 2023 12:54
@janmasrovira janmasrovira marked this pull request as ready for review February 10, 2023 14:31
@jonaprieto
Copy link
Collaborator

Can we have some form of testing for this, possibly reusing the example given in:

@janmasrovira
Copy link
Collaborator Author

Can we have some form of testing for this, possibly reusing the example given in:

I added a smoke test

@janmasrovira janmasrovira force-pushed the juvix-init-generates-an-invalid-juvix-package-file branch from b1490d4 to b1e03be Compare February 10, 2023 16:24
@jonaprieto jonaprieto force-pushed the juvix-init-generates-an-invalid-juvix-package-file branch from b1e03be to 973df12 Compare February 10, 2023 16:27
@janmasrovira janmasrovira merged commit f897fc2 into main Feb 10, 2023
@janmasrovira janmasrovira deleted the juvix-init-generates-an-invalid-juvix-package-file branch February 10, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaprieto jonaprieto jonaprieto approved these changes

Assignees

@janmasrovira janmasrovira

Labels
fix:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

juvix init generates an invalid Juvix package file
2 participants
@janmasrovira @jonaprieto