Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt benchmarks to the new pipeline #1795

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Adapt benchmarks to the new pipeline #1795

merged 1 commit into from
Feb 1, 2023

Conversation

lukaszcz
Copy link
Collaborator

@lukaszcz lukaszcz commented Feb 1, 2023

Closes #1742

@lukaszcz lukaszcz added this to the 0.3 - Valencia milestone Feb 1, 2023
@lukaszcz lukaszcz self-assigned this Feb 1, 2023
paulcadman
paulcadman approved these changes Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@paulcadman paulcadman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine - we will see any issues when the benchmarks run on the nightly build.

@lukaszcz
Copy link
Collaborator Author

lukaszcz commented Feb 1, 2023

Looks fine - we will see any issues when the benchmarks run on the nightly build.

Should be fine. I checked the Juvix programs compile and give the same results as before.

@lukaszcz lukaszcz merged commit 5ec8064 into main Feb 1, 2023
@lukaszcz lukaszcz deleted the fix-benchmarks branch February 1, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcadman paulcadman paulcadman approved these changes

Assignees

@lukaszcz lukaszcz

Labels
benchmark
Projects
None yet
Milestone
0.3 - Valencia
Development

Successfully merging this pull request may close these issues.

Adapt the examples, tests and the standard library to work with the new pipeline
2 participants
@lukaszcz @paulcadman