Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debugging builtin functions trace and fail #1771

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Add debugging builtin functions trace and fail #1771

merged 2 commits into from
Jan 27, 2023

Conversation

jonaprieto
Copy link
Collaborator

@jonaprieto jonaprieto added the enhancement New feature or request label Jan 26, 2023
@jonaprieto jonaprieto added this to the 0.3 - Valencia milestone Jan 26, 2023
@jonaprieto jonaprieto self-assigned this Jan 26, 2023
lukaszcz
lukaszcz requested changes Jan 26, 2023
View reviewed changes
Copy link
Collaborator

@lukaszcz lukaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trace should be lazy in its second argument. Otherwise, the order of the trace messages is mangled.

@jonaprieto jonaprieto mentioned this pull request Jan 27, 2023
Closed
@lukaszcz lukaszcz self-requested a review January 27, 2023 11:10
@jonaprieto jonaprieto merged commit 544bddb into main Jan 27, 2023
@jonaprieto jonaprieto deleted the jonaprieto/issue1731 branch January 27, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janmasrovira janmasrovira janmasrovira left review comments

@lukaszcz lukaszcz lukaszcz approved these changes

Assignees

@jonaprieto jonaprieto

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.3 - Valencia
Development

Successfully merging this pull request may close these issues.

Add debugging builtin functions
3 participants
@jonaprieto @lukaszcz @janmasrovira