Use absolute path in Core Evaluator to generate source file location #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filepaths within a `Loc` must now be absolute or an error is thrown when `mkLoc` is called. This `Loc` is used when displaying errors. This commit converts the Core evaluator filepath to an absolute path before calling `mkLoc`.
janmasrovira
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filepaths within a
Locmust now be absolute or an error is thrown whenmkLocis called. ThisLocis used when displaying errors.This commit converts the Core evaluator filepath to an absolute path before calling
mkLoc.Before this fix, the Core evaluator would crash if it encountered an error instead of displaying the error if called on a relative path.