Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix let expressions in the repl #1763

Merged
merged 4 commits into from
Jan 25, 2023
Merged

Fix let expressions in the repl #1763

merged 4 commits into from
Jan 25, 2023

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Jan 24, 2023 •
edited by jonaprieto
Loading

@janmasrovira janmasrovira added this to the 0.3 - Valencia milestone Jan 24, 2023
@janmasrovira janmasrovira self-assigned this Jan 24, 2023
@janmasrovira janmasrovira linked an issue Jan 24, 2023 that may be closed by this pull request
Let-expressions don't work in the REPL #1739
Closed
@janmasrovira janmasrovira force-pushed the 1739-let-expressions-dont-work-in-the-repl branch from 02a2418 to a2fe8d7 Compare January 24, 2023 16:16
@jonaprieto jonaprieto force-pushed the 1739-let-expressions-dont-work-in-the-repl branch from a2fe8d7 to bd18169 Compare January 24, 2023 16:22
jonaprieto
jonaprieto previously approved these changes Jan 24, 2023
View reviewed changes
@janmasrovira janmasrovira force-pushed the 1739-let-expressions-dont-work-in-the-repl branch from bd18169 to 27912c4 Compare January 24, 2023 16:29
paulcadman
paulcadman approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@paulcadman paulcadman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@paulcadman paulcadman merged commit 830afad into main Jan 25, 2023
@paulcadman paulcadman deleted the 1739-let-expressions-dont-work-in-the-repl branch January 25, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcadman paulcadman paulcadman approved these changes

@jonaprieto jonaprieto jonaprieto left review comments

Assignees

@janmasrovira janmasrovira

Labels
fix:bug repl
Projects
None yet
Milestone
0.3 - Valencia
Development

Successfully merging this pull request may close these issues.

Let-expressions don't work in the REPL
3 participants
@janmasrovira @paulcadman @jonaprieto