Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve arity inference for repl expressions #1762

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Improve arity inference for repl expressions #1762

merged 2 commits into from
Jan 24, 2023

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Jan 24, 2023 •
edited by jonaprieto
Loading

Now the arity checker does not add an unnecessary hole and so the repl displays the type properly:
image

@janmasrovira janmasrovira added this to the 0.3 - Valencia milestone Jan 24, 2023
@janmasrovira janmasrovira self-assigned this Jan 24, 2023
@janmasrovira janmasrovira linked an issue Jan 24, 2023 that may be closed by this pull request
REPL always tries to infer all holes instead of displaying polymorphic types #1721
Closed
paulcadman
paulcadman previously approved these changes Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@paulcadman paulcadman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful - thank you!

paulcadman
paulcadman previously approved these changes Jan 24, 2023
View reviewed changes
@janmasrovira janmasrovira force-pushed the 1721-repl-always-tries-to-infer-all-holes-instead-of-displaying-polymorphic-types branch from 0074c89 to 6468be8 Compare January 24, 2023 15:15
@janmasrovira janmasrovira changed the title improve arity inference for repl expressions Improve arity inference for repl expressions Jan 24, 2023
@paulcadman paulcadman merged commit c1020f9 into main Jan 24, 2023
@paulcadman paulcadman deleted the 1721-repl-always-tries-to-infer-all-holes-instead-of-displaying-polymorphic-types branch January 24, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcadman paulcadman paulcadman approved these changes

Assignees

@janmasrovira janmasrovira

Labels
aritychecker fix:bug repl
Projects
None yet
Milestone
0.3 - Valencia
Development

Successfully merging this pull request may close these issues.

REPL always tries to infer all holes instead of displaying polymorphic types
2 participants
@janmasrovira @paulcadman