Fix macOS CI build #1747
Merged
Fix macOS CI build #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to use the homebrew Clang/LLVM installation to build the Juvix runtime because macOS ships with a version of Clang/LLVM that does not support the wasi target. The GitHub action runner agent has the homebrew packaged Clang/LLVM installed but it is not on the shell PATH. We were using `brew --prefix llvm@14` to point to the homebrew Clang/LLVM installation. However this breaks when the runner image is updated to a new version of llvm. So we switch to using `brew --prefix llvm` which will resolve to the latest (and in this case only) version of homebrew Clang/LLVM. This will be stable when Clang/LLVM is updated to a new version.
jonaprieto
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use the homebrew Clang/LLVM installation to build the Juvix runtime because macOS ships with a version of Clang/LLVM that does not support the wasi target.
The GitHub action runner agent has the homebrew packaged Clang/LLVM installed but it is not on the shell PATH.
We were using
brew --prefix llvm@14to point to the homebrew Clang/LLVM installation. However this breaks when the runner image is updated to a new version of llvm.So we switch to using
brew --prefix llvmwhich will resolve to the latest (and in this case only) version of homebrew Clang/LLVM. This will be stable when Clang/LLVM is updated to a new version.