Update CI to install Smoke, Github actions, and Makefile fixes #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcadman
previously approved these changes
Jan 17, 2023
jonaprieto
force-pushed
the
smoke-fork
branch
from
d400fb0
to
4063dd3
Compare
jonaprieto
force-pushed
the
smoke-fork
branch
4 times, most recently
from
4d55588
to
e076b04
Compare
jonaprieto
force-pushed
the
main
branch
2 times, most recently
from
eaadc06
to
8be1fcc
Compare
jonaprieto
force-pushed
the
smoke-fork
branch
from
d6ecbba
to
c6cb0ab
Compare
jonaprieto
force-pushed
the
smoke-fork
branch
6 times, most recently
from
4342f4d
to
de3a39b
Compare
jonaprieto
force-pushed
the
smoke-fork
branch
from
510872d
to
b8da2a7
Compare
jonaprieto
changed the title
jonaprieto
force-pushed
the
smoke-fork
branch
from
b8da2a7
to
8326a2e
Compare
|
We should document / communicate which versions of hlint and ormolu are now being used by the CI so we can make sure we have the correct versions installed locally. The documentation can be done in a separate PR. |
paulcadman
previously approved these changes
Jan 24, 2023
paulcadman
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some maintenance at different levels to the CI config, the Make file, and formatting.
Most of the actions used by the CI related to haskell, ormolu, hlint and pre-commit have been updated because Github requires NodeJS 16. This change removes all the old warnings related to nodeJs.
In the case of ormolu, the new version makes us format some files that were not formatted before, similarly with hlint.
The CI has been updated to use the latest version of the Smoke testing framework, which introduced installation of the dependencies for Linux (libicu66) and macOS (icu4c) in the CI. In the case of macOS, the CI uses a binary for smoke. For Linux, we use stack to build smoke from the source. The source here is in a fork of the official Smoke repo. Such includes some features/changes that are not yet in the official repo.
The Makefile runs the ormolu and hlint targets using as a path for the binaries the environment variables ORMOLU and HLINT. Thus, export those variables in your environment before running
make check,make formatormake hlint. Otherwise, the Makefile will use the binaries providedby
stack.