Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not filter implicit args in internal to core translation #1728

Merged
merged 2 commits into from
Jan 16, 2023
Merged

Do not filter implicit args in internal to core translation #1728

merged 2 commits into from
Jan 16, 2023

Commits on Jan 16, 2023

  1. Do not filter implicit args in internal to core translation 

    Apart from removing this filter from function and application
translation, this required the following changes:

ConstructorInfo:
The _constructorArgsNum field must include the number of type parameters
of its inductive type.

PatternConstructorApp:
The pattern arguments must include wildcards for the implicit type
parameters passed to the constructor.

BuiltinIf:
The BuiltinIf expression is passed an implicit type argument that must
be removed when translating to Core if.

LitString:
A literal string is a function with an implcit type argument. So this
must be a translated to a lambda where the type argument is ignored.
    @paulcadman
    paulcadman committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    da9354e View commit details
    Browse the repository at this point in the history

  2. Use guards instead of if

    @paulcadman
    paulcadman committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    6574d52 View commit details
    Browse the repository at this point in the history