Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add printString and printBool support to legacy C backend #1698

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

paulcadman
Copy link
Collaborator

@paulcadman paulcadman commented Jan 4, 2023

This PR implements printString and printBool builtins for the legacy C backend. Previously IO for strings was done using compile blocks with included C code.

Fixes #1696

@paulcadman paulcadman added this to the 0.2.9 milestone Jan 4, 2023
@paulcadman paulcadman self-assigned this Jan 4, 2023
lukaszcz
lukaszcz previously approved these changes Jan 4, 2023
Copy link
Collaborator

@lukaszcz lukaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have the same problem with printBool? It's declared as a builtin axiom in the standard library, but I don't see it anywhere in c-runtime.

@paulcadman
Copy link
Collaborator Author

Don't we have the same problem with printBool? It's declared as a builtin axiom in the standard library, but I don't see it anywhere in c-runtime.

You're right, I missed it. I will add it to this PR

@paulcadman paulcadman changed the title Add printString support to legacy C backend Add printString and printBool support to legacy C backend Jan 4, 2023
@lukaszcz lukaszcz merged commit 8ef970d into main Jan 4, 2023
@lukaszcz lukaszcz deleted the printString-legacy-c branch January 4, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiling programs with IO to native code no longer works
2 participants