Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser labels #1535

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Parser labels #1535

merged 2 commits into from
Sep 16, 2022

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Sep 14, 2022 •
edited
Loading

This PR adds some labels to the parser so that some error messages are more useful. It helps with #1483. Now the errors becomes

23 | id _ a = a;
   |           ^^
unexpected ";<newline>"
expecting ":=", or '<pattern>'

@janmasrovira janmasrovira added this to the 0.2.6 milestone Sep 14, 2022
@janmasrovira janmasrovira self-assigned this Sep 14, 2022
@janmasrovira janmasrovira force-pushed the parser-labels branch 2 times, most recently from 303a136 to f78ba93 Compare September 14, 2022 14:16
@janmasrovira janmasrovira marked this pull request as ready for review September 14, 2022 14:17
@janmasrovira janmasrovira merged commit 5797133 into main Sep 16, 2022
@janmasrovira janmasrovira deleted the parser-labels branch September 16, 2022 09:02
@jonaprieto jonaprieto mentioned this pull request Sep 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcadman paulcadman paulcadman approved these changes

Assignees

@janmasrovira janmasrovira

Labels
error-messaging
Projects
None yet
Milestone
0.2.6
Development

Successfully merging this pull request may close these issues.
2 participants
@janmasrovira @paulcadman