Make comma a delimiter #1525
Merged
Make comma a delimiter #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcadman
force-pushed
the
comma-delimiter
branch
from
e0f82d9
to
af85c8b
Compare
paulcadman
approved these changes
Sep 12, 2022
lukaszcz
force-pushed
the
comma-delimiter
branch
from
af85c8b
to
31c21a6
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the category of non-keyword delimiters into the lexer. Delimiters can be identifiers only by themselves, i.e., they do not combine with other characters. For now, the comma
,is the only delimiter. This allows the users not to write spaces before commas and still have them recognized as separate identifiers, as a nearly-universal convention dictates.Fixes the most important part of issue #1495.