Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a proper type to literal natural numbers #1453

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Aug 12, 2022

Before this PR, literal natural numbers were assigned the type {A : Type} -> A.
Now, when the type checker finds a literal number, it checks that the builtin natural numbers have been defined and it gives it the proper type. This change was easy. Most of the changed lines are about fixing tests.

@janmasrovira janmasrovira added this to the 0.2.3 milestone Aug 12, 2022
@janmasrovira janmasrovira self-assigned this Aug 12, 2022
@janmasrovira janmasrovira linked an issue Aug 12, 2022 that may be closed by this pull request
Copy link
Collaborator

@paulcadman paulcadman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@janmasrovira janmasrovira merged commit 8e1a4dc into main Aug 12, 2022
@janmasrovira janmasrovira deleted the 1452-give-proper-type-to-literal-natural-numbers branch August 12, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give proper type to literal natural numbers
2 participants