WASM import all non-compile axioms with alphanum names in entrypoint #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcadman
force-pushed
the
non-compile-axiom-import-name
branch
2 times, most recently
from
13be7f0
to
189a227
Compare
|
Awesome! Could you please add one entry in the documentation about this particular example, the Hello World? I'd put it in the section Tutorials. |
This commit adds `__attribute__((input_name(<name>)))` to the type signature of all axioms that do not have a compile block. This indicates to the compiler that this function should be added to the input table of the WASM binary. Adds a test that an imported function can be called from Juvix.
paulcadman
force-pushed
the
non-compile-axiom-import-name
branch
from
a5962e6
to
557ca1d
Compare
jonaprieto
approved these changes
Aug 2, 2022
This was
linked to
issues
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the implementation for #1355
This PR adds
__attribute__((import_name(<name>))declarations to every type signature corresponding to axioms with no-compile block that has an alpha numeric name in the entry point module (so that it can safely be present in the output C file).This causes these functions to be present in the import table of the resulting WASM module.
To try this out:
cd tests/positive/MiniC/ImportExportName juvix compile --runtime standalone Input.juvixTo see the imports and exports of the module:
wasmer inspect Input.wasm Type: wasm Size: 172 B Imports: Functions: "env"."hostDisplayString": [I32] -> [] Memories: Tables: Globals: Exports: Functions: "juvixRender": [] -> [] Memories: "memory": not shared (2 pages..) Tables: Globals:You can then inject an implementation of
hostDisplayStringfrom nodeJS, which is called in Juvix and invoke thejuvixRenderJuvix function from the nodeJS file with:node input.js Hello World from Juvix!