Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break up LetRec nodes in Core into strongly connected components. #1677

Closed
lukaszcz opened this issue Dec 22, 2022 · 0 comments · Fixed by #1894
Closed

Break up LetRec nodes in Core into strongly connected components. #1677

lukaszcz opened this issue Dec 22, 2022 · 0 comments · Fixed by #1894
Assignees
@janmasrovira
Labels
core Related to JuvixCore enhancement New feature or request
Milestone
0.3.1

Comments

@lukaszcz
Copy link
Collaborator

lukaszcz commented Dec 22, 2022 •
edited
Loading

Break up LetRec nodes into true strongly connected components based on a local analysis of the call graph. This may have a significant impact on performance if each let-block in the front-end is translated naively into a single LetRec node in Core. This also affects the code generated for the GEB backend.
@lukaszcz lukaszcz added enhancement New feature or request pending-review labels Dec 22, 2022
@lukaszcz lukaszcz added this to the 0.4 milestone Dec 22, 2022
@lukaszcz lukaszcz added core Related to JuvixCore and removed pending-review labels Mar 9, 2023
@janmasrovira janmasrovira self-assigned this Mar 14, 2023
@janmasrovira janmasrovira linked a pull request Mar 15, 2023 that will close this issue
Automatically detect and split mutually recursive blocks in let expressions #1894
Merged
@janmasrovira janmasrovira mentioned this issue Mar 15, 2023
Merged
paulcadman pushed a commit that referenced this issue Mar 17, 2023
@janmasrovira
Automatically detect and split mutually recursive blocks in let expre…
934a273 
…ssions (#1894)

- Closes #1677
@lukaszcz lukaszcz modified the milestones: 0.6.0, 0.3.1 Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janmasrovira janmasrovira

Labels
core Related to JuvixCore enhancement New feature or request
Projects
None yet
Milestone
0.3.1
Development

Successfully merging a pull request may close this issue.

Automatically detect and split mutually recursive blocks in let expressions anoma/juvix
2 participants
@lukaszcz @janmasrovira