Widens the accepted symbol list (#1385)

* Changed the valid symbols from inclusvie to exclusive * Add test using the new valid symbols
anoma · Jul 18, 2022 · d7ad691 · d7ad691
1 parent 2ea049c
commit d7ad691
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 13 deletions.
diff --git a/src/Juvix/Syntax/Concrete/Lexer.hs b/src/Juvix/Syntax/Concrete/Lexer.hs
@@ -118,19 +118,11 @@ validTailChar :: Char -> Bool
 validTailChar c =
   isAlphaNum c || validFirstChar c
 
+reservedSymbols :: [Char]
+reservedSymbols = "\";(){}[].≔λ\\"
+
 validFirstChar :: Char -> Bool
-validFirstChar c =
-  or
-    [ isLetter c,
-      cat == MathSymbol,
-      cat == CurrencySymbol,
-      cat == ModifierLetter,
-      c `elem` extraAllowedChars
-    ]
-  where
-    extraAllowedChars :: [Char]
-    extraAllowedChars = "_'-*,&"
-    cat = generalCategory c
+validFirstChar c = not $ isNumber c || isSpace c || (c `elem` reservedSymbols)
 
 dot :: forall e m. MonadParsec e Text m => m Char
 dot = P.char '.'

diff --git a/test/Scope/Positive.hs b/test/Scope/Positive.hs
@@ -199,5 +199,10 @@ tests =
       "Import embedded standard library"
       "StdlibImport"
       StdlibInclude
-      "StdlibImport.juvix"
+      "StdlibImport.juvix",
+    PosTest
+      "Check Valid Symbols"
+      ""
+      StdlibInclude
+      "Symbols.juvix"
   ]
diff --git a/tests/positive/Symbols.juvix b/tests/positive/Symbols.juvix
@@ -0,0 +1,31 @@
+module Symbols;
+
+  open import Stdlib.Data.Nat;
+
+  ╘⑽╛ : ℕ;
+  ╘⑽╛ ≔ suc nine;
+
+   -- no - function!?
+   - : ℕ -> ℕ -> ℕ;
+   - ≔ (+);
+
+  （-） : ℕ -> ℕ -> ℕ;
+  （-） ≔ (-);
+
+  （*） : ℕ -> ℕ -> ℕ;
+  （*） ≔ (*);
+
+  infixl 6 －;
+  － : ℕ -> ℕ -> ℕ;
+  － ≔ （-）;
+
+  infixl 7 ·;
+  · : ℕ -> ℕ -> ℕ;
+  · ≔ （*）;
+
+  （0） : ℕ;
+  （0） ≔ ╘⑽╛ － ╘⑽╛ · zero;
+
+  主功能 : ℕ;
+  主功能 ≔ （0）;
+end;