Add negative Package loading tests

test/Main.hs

@@ -10,6 +10,7 @@ import Examples qualified
 import Format qualified
 import Formatter qualified
 import Internal qualified
+import Package qualified
 import Parsing qualified
 import Reachability qualified
 import Runtime qualified
@@ -43,7 +44,8 @@ fastTests =
       Typecheck.allTests,
       Reachability.allTests,
       Format.allTests,
-      Formatter.allTests
+      Formatter.allTests,
+      Package.allTests
     ]
 
 main :: IO ()

test/Package.hs

@@ -0,0 +1,10 @@
+module Package
+  ( allTests,
+  )
+where
+
+import Base
+import Package.Negative qualified as N
+
+allTests :: TestTree
+allTests = testGroup "Package loading tests" [N.allTests]

test/Package/Negative.hs

@@ -0,0 +1,68 @@
+module Package.Negative where
+
+import Base
+import Juvix.Compiler.Pipeline.Package
+import Juvix.Compiler.Pipeline.Package.Loader.Error
+
+type FailMsg = String
+
+data NegTest a = NegTest
+  { _name :: String,
+    _relDir :: Path Rel Dir,
+    _checkErr :: a -> Maybe FailMsg
+  }
+
+root :: Path Abs Dir
+root = relToProject $(mkRelDir "tests/negative/Package")
+
+testDescr :: (Typeable a) => NegTest a -> TestDescr
+testDescr NegTest {..} =
+  let tRoot = root <//> _relDir
+   in TestDescr
+        { _testName = _name,
+          _testRoot = tRoot,
+          _testAssertion = Single $ do
+            res <- withTempDir' (runM . runError . runFilesIO . readPackage tRoot . CustomBuildDir . Abs)
+            case mapLeft fromJuvixError res of
+              Left (Just err) -> whenJust (_checkErr err) assertFailure
+              Left Nothing -> assertFailure "An error ocurred but it was not when reading the package."
+              Right {} -> assertFailure "There was no error when reading the package"
+        }
+
+allTests :: TestTree
+allTests =
+  testGroup
+    "Package loading negative tests"
+    ( map (mkTest . testDescr) packageErrorTests
+    )
+
+wrongError :: Maybe FailMsg
+wrongError = Just "Incorrect error"
+
+packageErrorTests :: [NegTest PackageLoaderError]
+packageErrorTests =
+  [ NegTest
+      "package YAML parse error"
+      $(mkRelDir "YamlParseError")
+      $ \case
+        PackageLoaderError _ ErrPackageYamlParseError {} -> Nothing
+        _ -> wrongError,
+    NegTest
+      "lockfile YAML parse error"
+      $(mkRelDir "InvalidLockfile")
+      $ \case
+        PackageLoaderError _ ErrLockfileYamlParseError {} -> Nothing
+        _ -> wrongError,
+    NegTest
+      "package YAML invalid version"
+      $(mkRelDir "YamlInvalidVersion")
+      $ \case
+        PackageLoaderError _ ErrVersionParseError {} -> Nothing
+        _ -> wrongError,
+    NegTest
+      "package YAML duplicate dependencies"
+      $(mkRelDir "YamlDuplicateDependencies")
+      $ \case
+        PackageLoaderError _ ErrDuplicateDependencyError {} -> Nothing
+        _ -> wrongError
+  ]

tests/negative/Package/InvalidLockfile/juvix.lock.yaml

@@ -0,0 +1 @@
+dependencies: 123

tests/negative/Package/YamlDuplicateDependencies/juvix.yaml

@@ -0,0 +1,10 @@
+name: abc
+dependencies:
+  - git:
+      url: repo
+      name: dep
+      ref: abc
+  - git:
+      url: repo
+      name: dep
+      ref: abc

tests/negative/Package/YamlInvalidVersion/juvix.yaml

@@ -0,0 +1,2 @@
+name: abc
+version: def

tests/negative/Package/YamlParseError/juvix.yaml

@@ -0,0 +1 @@
+name: 123