Remove hlint from the CI and pre-commit config (#1759)

anoma · Jan 24, 2023 · 2094e5d · 2094e5d
1 parent 807b3b1
commit 2094e5d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 27 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -50,19 +50,6 @@ jobs:
         with:
           clang-format-version: '15'
           check-path: 'runtime/src'
-  hlint:
-    runs-on: ubuntu-latest
-    steps:
-    - uses: actions/checkout@v3
-    - name: 'Set up HLint'
-      uses: haskell/actions/hlint-setup@v2
-      with:
-        version: '3.5'
-    - name: 'Run HLint'
-      uses: haskell/actions/hlint-run@v2
-      with:
-        path: '["src/", "app/", "test/"]'
-        # fail-on: warning
 
   pre-commit:
     runs-on: ubuntu-latest

diff --git a/.hlint.yaml b/.hlint.yaml
@@ -2,9 +2,9 @@
 
 - arguments: [--color]
 
-# --------------------------------------------------------------------------------
+# ------------------------------------------------------------------------------
 # RESTRICTIONS
-# --------------------------------------------------------------------------------
+# ------------------------------------------------------------------------------
 
 - extensions:
   - default: false
@@ -50,15 +50,15 @@
   - {name: Data.List.NonEmpty.nub, within: []}
   - {name: Data.List.NonEmpty.nubBy, within: []}
 
-# --------------------------------------------------------------------------------
+# ------------------------------------------------------------------------------
 # OTHER HINTS
-# --------------------------------------------------------------------------------
+# ------------------------------------------------------------------------------
 
 # - warn: {name: Use explicit module export list}
 
-# --------------------------------------------------------------------------------
+# ------------------------------------------------------------------------------
 # HINTS
-# --------------------------------------------------------------------------------
+# ------------------------------------------------------------------------------
 
 - error: {lhs: idea Warning, rhs: warn}
 - error: {lhs: idea Suggestion, rhs: suggest}
@@ -69,9 +69,9 @@
 - error: {lhs: occNameString (occName x), rhs: occNameStr x}
 - error: {lhs: noLoc (HsVar noExtField (noLoc (mkRdrUnqual (mkVarOcc x)))), rhs: strToVar x}
 
-# --------------------------------------------------------------------------------
+# ------------------------------------------------------------------------------
 # IGNORES
-# --------------------------------------------------------------------------------
+# ------------------------------------------------------------------------------
 
 - ignore: {name: Use let, within: [Test.All]}
 - ignore: {name: Use String}

diff --git a/.pre-commit-hooks.yaml b/.pre-commit-hooks.yaml
@@ -1,9 +1,3 @@
--   id: hlint
-    name: hlint
-    description: Run Hlint linter
-    entry: make hlint
-    language: system
-
 -   id: ormolu
     name: ormolu
     description: Run Ormolu linter