Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clientmodel 3p pageable #21

Closed
wants to merge 51 commits into from

Conversation

annelo-msft
Copy link
Owner

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

jaschrep-msft and others added 30 commits May 9, 2024 13:36
* Enable validation in CI

* remove ci check

* ignore cli version

* templateHash

* re-record storage and signalr

* Fix bug in search model factory

* Search

* mode

* public network access

* fix

* Fix nullability used in ternary

* override start time to exclude bicep build
* prepare release for Azure.ResourceManager.Compute

* remove the liveonly attributes

* remove more liveonly attributes

* change to stable
* Increment package version after release of Azure.Maps.Rendering

* Increment package version after release of Azure.Maps.Search
* chore: add tsg link in error messages

* pr feedback

* add missing error parser
* Update Generator Version 3.0.0-beta.20240510.1

* Update SDK codes de_he_2

* Update SDK codes he_mi_3

* Update SDK codes ad_co_0

* Update SDK codes mi_pu_4

* Update SDK codes pu_sq_5

* Update SDK codes co_de_1

* wip

* wip

* fix communication

---------

Co-authored-by: nisha-bhatia <67986960+nisha-bhatia@users.noreply.github.com>
* Add WebPubSub provisioning

* Add api

* Resolve comments

* Fix build failure

* Fix tests
* Update Generator Version 3.0.0-beta.20240511.1

* Update SDK codes mi_pu_4
Switch ApiScan to use Azure CLI auth. While I'm not particularly happy with this approach, the APIScan tool/task doesn't support WIF directly currently so we are moving to use the Azure CLI login instead.
…entation (Azure#43840)

* Add async and sync enumerable client results

* Implement IAsyncDisposable

* Remove constrant and disposable; update ClientResult so response can be replaced in a polling paradigm

* rename and upate tests

* initial addition of files from joseharriaga/openai-in-typespec#68

* make it build

* hello world test

* bootstrap more tests

* more internal tests

* adding enumerator tests; haven't figured out the batch piece yet

* Make batch test pass

* remove collection-event functionality and add tests for public type

* reshuffle

* Add mock convenience SSE type to give POC of lazy request sending

* add tests of delayed request

* Add BinaryData factory method

* remove funcs for creating enumerators

* renames

* postpone call to protocol method from convenience APIs

* implement IAsyncDisposable correctly

* initial pass over cancellation token

* Per FDG, throw OperationCanceledException if cancellation token is cancelled.

* remove factory method taking Func<T> and provide example of layering convenience implementation in a way that postpones sending the request

* rename internal types and WIP adding reader tests

* nits

* parameterize terminal event; TBD to provide virtual method on collection type

* WIP: nits

* WIP: added concatenation of data lines per SSE spec

* updates and bug fixes

* add tests and update per SSE spec

* WIP: refactor to reuse field processing across sync and async methods

* make look a little more like the BCL type proposal

* simplify field implementation a bit

* cosmetic reworking of creating an event from a pending event

* Remove factory method from public API; move MockSseClient to Tests.Internal to access internal SSE types

* update API; reimplement mock client implementations without internal BinaryData enumerable

* Add sync client result collection abstraction

* tidy up and add tests

* add default constructor to ClientResult

* more tidy-up

* rename and add refdocs

* comments

* pr fb

* rework last event id and retry per BCL design shift

* add CHANGELOG entry
@annelo-msft
Copy link
Owner Author

Closing in favor of Azure#44026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.