Skip to content

Commit

Permalink
[exporter/datadogexporter] Treat network error as temporary error to …
Browse files Browse the repository at this point in the history
…make sure log events are delivered reliably (open-telemetry#24550).
  • Loading branch information
anmalysh-yb committed Aug 23, 2023
1 parent 653ab06 commit 8c1d7e9
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions exporter/datadogexporter/internal/logs/sender.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (

"github.com/DataDog/datadog-api-client-go/v2/api/datadog"
"github.com/DataDog/datadog-api-client-go/v2/api/datadogV2"
"go.opentelemetry.io/collector/consumer/consumererror"
"go.opentelemetry.io/collector/exporter/exporterhelper"
"go.uber.org/zap"

Expand Down Expand Up @@ -85,9 +84,9 @@ func (s *Sender) handleSubmitLog(ctx context.Context, batch []datadogV2.HTTPLogI
s.logger.Error("Failed to send logs", zap.Error(err), zap.String("msg", string(b[:n])), zap.String("status_code", r.Status))
return err
}
// If response is nil assume permanent error.
// The error will be logged by the exporter helper.
return consumererror.NewPermanent(err)
// If response is nil assume network error.
s.logger.Error("Failed to send logs - no response received", zap.Error(err))
return err
}
return nil
}

0 comments on commit 8c1d7e9

Please sign in to comment.