move node_modules into root folder [action required]

[dae]

Recommend removing ts/node_modules folder before attempting to
build after this update.

This moves ts/node_modules into the root of the project to work around
#1405 (comment)

Also fixes the sass errors shown when running scripts/svelte-check

[hgiesel]

I think we're getting closer, but this still does not work for me.

With the PR as is, VS Code can now find definitions. E.g. when opening ts/editor/TemplateButtons.svelte, right-clicking on ButtonGroup and "Go to definition", will lead me to bazel-bin/ts/editor/ButtonGroup.svelte.d.ts. This means no more red squiggles, however the component's props/slots/events are still not typechecked.

In comparison to that, when removing "." from rootDirs, like I mentioned in #1405, the Go to definition will lead me to ts/editor/ButtonGroup.svelte, which enables typechecking on props/slots/events for me (this approach works in this PR too, however it still breaks typechecking for tr).

[dae]

Sorry, we could have avoided some back and forth if I'd asked you to explain the problem you were experiencing in more detail earlier :-)

The "go to definition" being broken was mentioned in a3d9f90:

The only downside seems to be that cmd+clicking
on a Svelte imports jumps to the .d.ts file instead of the original now;
presumably they'll fix that in a future plugin update.

It appears the Svelte plugin for VS Code will preferentially use the .d.ts file over the .svelte file. It's a trade-off: we lose the ability to jump directly to the .svelte file, but the editor now understands non-default exports from the Svelte module as well, so { components } in editor/index.ts displays correctly for example.

I imagine what's happening when you remove "." from rootDirs is you break the build :-). If you run it from a terminal, you get this:

dae@dip:code/dtop/ts% ../node_modules/.bin/tsc -b  .
lib/i18n_helpers.ts:82:33 - error TS2307: Cannot find module './i18n' or its corresponding type declarations.

82 import type { ModuleName } from "./i18n";
...

That prevents VS Code from reading the generated sources, and presumably prevents it from reading the svelte.d.ts files as well - so it behaves as if there were no svelte.d.ts files, allowing you to jump to their definitions instead.

The reason Bazel still works is because it's manually including args like --rootDir as it builds each project.

As for the lack of type checking, it appears the .d.ts files we're creating do not have the properties set correctly, eg:

import { SvelteComponentTyped } from "svelte";
declare const __propDef: any;
export declare type SpinBoxProps = typeof __propDef.props;
export declare type SpinBoxEvents = typeof __propDef.events;
export declare type SpinBoxSlots = typeof __propDef.slots;
export default class SpinBox extends SvelteComponentTyped<SpinBoxProps, SpinBoxEvents, SpinBoxSlots> {
}
export {};

I believe they were working before, and I suspect if they can be fixed, the editor typechecking will work again - will look into it.

[dae]

Does the latest commit resolve your remaining issues?

[hgiesel]

Yes! Awesome, look forward to the full typing experience :)