Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More uniform file naming #1266

Merged
merged 1 commit into from
Jul 1, 2021
Merged

More uniform file naming #1266

merged 1 commit into from
Jul 1, 2021

Conversation

hgiesel
Copy link
Contributor

@hgiesel hgiesel commented Jun 30, 2021

kebap-case for .ts, .scss, .html, and directories.

I don't really care whether JS/TS files use camelCase, or kebap-case, I just care that it's uniform :)

@dae
Copy link
Member

dae commented Jul 1, 2021

Yeah, when I used ChangeNotetype I thought we'd need to make a change down the line to make things consistent ^_^; It would be nice if there was one clear direction here! A brief survey of some of our dependencies:

svelte: snake_case
d3: camelCase
typescript: camelCase
lodash: camelCase
eslint: kebab-case
yarn: kebab-case

One argument against kebab-case is that Bazel's Python support can choke on the hyphens, but we probably
won't need to place Python libraries inside /ts, and html-filter is working fine already, so happy to merge this once the conflicts are resolved.

kebap-case for .ts, .scss, .html, and directories
@hgiesel
Copy link
Contributor Author

hgiesel commented Jul 1, 2021

One thing I should also mention, that at first I tried to use camelCase for all JS/TS files, but setting

esbuild(
    name = "deck-options",
    ....
    output = "deckOptions.js",
    output_css = "deck-options.css",
    ...
)

failed, and could only be fixed by setting output and output_css to the same value.

@dae
Copy link
Member

dae commented Jul 1, 2021

Thanks Henrik!

@dae dae merged commit c01c4b6 into ankitects:main Jul 1, 2021
@hgiesel hgiesel deleted the renamelib branch July 11, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants