Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add a comment for the input field in the statistics page #3394

Closed
lukstbit opened this issue Aug 31, 2024 · 1 comment · Fixed by #3398
Closed

Request to add a comment for the input field in the statistics page #3394

lukstbit opened this issue Aug 31, 2024 · 1 comment · Fixed by #3398

Comments

@lukstbit
Copy link

This is a request to add a comment for the input field in the statistics page stating that it is used as a public API in other clients, something along the lines of:

"this form is an external API and should not be changed - other clients e.g. AnkiDroid programmatically update this form"

In Ankidroid we are using this input field to set the current deck(for stats displaying) only for the statistics screen as some users have asked. See relevant discussion at ankidroid/Anki-Android#15648 (review) . Tried to propose a PR but I don't know svelte.
Thank you!

@lukesbart
Copy link
Contributor

Sorry about making a mess with all these commits, it's my first time trying to contribute. I added the changed requested with the new comment.

dae added a commit to lukesbart/anki that referenced this issue Sep 20, 2024
dae added a commit that referenced this issue Sep 20, 2024
…#3394) (#3398)

* Add comment about the usage of the input field in the statistics page (#3394)

* Fix formatting issues (#3394)

* Update ts/routes/graphs/RangeBox.svelte

Co-authored-by: Mike Hardy <github@mikehardy.net>

* Update ts/routes/graphs/RangeBox.svelte

Co-authored-by: Mike Hardy <github@mikehardy.net>

---------

Co-authored-by: Damien Elmes <dae@users.noreply.github.com>
Co-authored-by: Mike Hardy <github@mikehardy.net>
@dae dae closed this as completed in #3398 Sep 20, 2024
twwn added a commit to twwn/anki that referenced this issue Sep 22, 2024
* master:
  Update translations
  Add an option to show image from editor in folder (ankitects#3412)
  Call the profile_did_open() hook earlier (ankitects#3421)
  Fix FSRS progress update issues (ankitects#3420)
  Update tooltip text (ankitects#3418)
  Fix pasting from the primary selection (ankitects#3413)
  Fix occlusion rounding bug (ankitects#3400)
  Add comment about the usage of the input field in the statistics page (ankitects#3394) (ankitects#3398)
  Possible to show “last” subdeck name in Browser? (ankitects#3387)
twwn pushed a commit to twwn/anki that referenced this issue Sep 22, 2024
…ankitects#3394) (ankitects#3398)

* Add comment about the usage of the input field in the statistics page (ankitects#3394)

* Fix formatting issues (ankitects#3394)

* Update ts/routes/graphs/RangeBox.svelte

Co-authored-by: Mike Hardy <github@mikehardy.net>

* Update ts/routes/graphs/RangeBox.svelte

Co-authored-by: Mike Hardy <github@mikehardy.net>

---------

Co-authored-by: Damien Elmes <dae@users.noreply.github.com>
Co-authored-by: Mike Hardy <github@mikehardy.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants
@lukesbart @lukstbit and others