Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature-1] Added Find_pairs_with_given_sum. in CPP #241

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

kiruba-r11
Copy link
Contributor

Related Issues

  • Finding whether a pair with a given sum in the Array exists or not, implemented in CPP

Closes: #233

Describe the changes you've made

I have completely implemented a CPP program that takes the input of array elements from the user and prints the true if aPair with given sum exists else prints false

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This has been tested by generating a set of random inputs using a generator and verified the outputs manually.

Describe if there is any unusual behavior of your code(Write NA if there isn't)

NA

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@kiruba-r11
Copy link
Contributor Author

@ankitapuri Please have a look at it

Copy link
Owner

@ankitapuri ankitapuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its always printing pair not found .

@kiruba-r11
Copy link
Contributor Author

@ankitapuri The problem works fine and I have tested it. I hope you would have entered the inputs in unsorted order, but the inputs for this question must be in sorted order to use the Two Pointer concept.

@ankitapuri
Copy link
Owner

image
see this

@kiruba-r11
Copy link
Contributor Author

@ankitapuri It's correct, there are pairs with sum 5, that is 1,4 and 2,3. The question is to return true or false about whether a pair is found or not, and not to print the pair found.

@ankitapuri ankitapuri merged commit bc283cf into ankitapuri:main Mar 4, 2021
@kiruba-r11 kiruba-r11 deleted the feature-1 branch March 5, 2021 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find pair with given sum
2 participants