Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android studio warnings - AdvancedSettingsFragment.kt #17134

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

sylshaw01
Copy link
Contributor

Purpose / Description

Reducing the amount of warnings given within android studio.

Fixes

Contributes towards #13282 [Cleanup]: Fix Android Studio Warnings

Approach

There was a broken reference in one of the comments. The configureSearchBar function had previously been moved from the HeaderFragment class to the Preferences class, but recently it was moved back and the comments describing it had not been updated.

How Has This Been Tested?

Only comments have been changed so testing does not apply.

Learning (optional, can help others)

I looked back in previous commits to see when that comment came to be, and investigated where the broken reference was meant to be pointing to.

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have performed a self-review of your own code

Copy link

welcome bot commented Sep 25, 2024

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@lukstbit lukstbit added the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Sep 25, 2024
@lukstbit lukstbit added this pull request to the merge queue Sep 25, 2024
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

Merged via the queue into ankidroid:main with commit ba8cce9 Sep 25, 2024
12 checks passed
@github-actions github-actions bot added this to the 2.19 release milestone Sep 25, 2024
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Sep 25, 2024
@sylshaw01 sylshaw01 deleted the Fix-Android-Studio-Warnings branch September 25, 2024 20:17
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Hi there @sylshaw01! This is the OpenCollective Notice for PRs merged from 2024-09-01 through 2024-09-30

If you are interested in compensation for this work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

Important

PLEASE NOTE: The process was updated in August 2024. Re-read the Payment Process page if you have not already.

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants