-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Android Studio Warnings #16740
Fix Android Studio Warnings #16740
Conversation
rebase these commits , make a single one ! |
69fb583
to
0e09808
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you for contributing. I've left two issues for you to fix and then we can merge this.
0e09808
to
add73df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes!
This is fine in terms of made changes, one small nitpick is to change the commit message to something more descriptive of the actual changes like:
Fix Android Studio warnings in several files
so we have a nicer git history.
Also, thanks for rebasing and force pushing, it makes merging easier.
sure |
Also awaiting a better commit message Thanks! |
add73df
to
62dce09
Compare
Hi there @jainv4156! This is the OpenCollective Notice for PRs merged from 2024-07-01 through 2024-07-31 If you are interested in compensation for this work, the process with details is here: https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid Important PLEASE NOTE: The process was updated in August 2024. Re-read the Payment Process page if you have not already. We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding. Thanks! |
Purpose / Description
Fix Android Studio code inspection warnings.
Fixes
Approach
Followed the suggestion of android studio
How Has This Been Tested?
Ran unit tests locally.
Checklist
Please, go through these checks before submitting the PR.