Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android Studio Warnings #16740

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

jainv4156
Copy link
Contributor

@jainv4156 jainv4156 commented Jul 15, 2024

Purpose / Description

Fix Android Studio code inspection warnings.

Fixes

Approach

Followed the suggestion of android studio

How Has This Been Tested?

Ran unit tests locally.

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@jainv4156 jainv4156 changed the title My feature branch Fix Android Studio Warnings Jul 15, 2024
@xenonnn4w
Copy link
Contributor

rebase these commits , make a single one !

@jainv4156 jainv4156 force-pushed the my-feature-branch branch from 69fb583 to 0e09808 Compare July 15, 2024 17:38
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for contributing. I've left two issues for you to fix and then we can merge this.

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt Outdated Show resolved Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/ReadText.kt Outdated Show resolved Hide resolved
@lukstbit lukstbit added the Needs Author Reply Waiting for a reply from the original author label Jul 16, 2024
@jainv4156 jainv4156 force-pushed the my-feature-branch branch from 0e09808 to add73df Compare July 16, 2024 07:32
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!
This is fine in terms of made changes, one small nitpick is to change the commit message to something more descriptive of the actual changes like:

Fix Android Studio warnings in several files

so we have a nicer git history.

Also, thanks for rebasing and force pushing, it makes merging easier.

@lukstbit lukstbit added the Needs Second Approval Has one approval, one more approval to merge label Jul 16, 2024
@jainv4156
Copy link
Contributor Author

sure

@david-allison david-allison added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jul 16, 2024
@david-allison
Copy link
Member

Also awaiting a better commit message

Thanks!

@jainv4156 jainv4156 force-pushed the my-feature-branch branch from add73df to 62dce09 Compare July 16, 2024 16:47
@lukstbit lukstbit removed the Needs Author Reply Waiting for a reply from the original author label Jul 17, 2024
@lukstbit lukstbit added this pull request to the merge queue Jul 17, 2024
Merged via the queue into ankidroid:main with commit 93c2f68 Jul 17, 2024
8 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jul 17, 2024
@github-actions github-actions bot added this to the 2.19 release milestone Jul 17, 2024
Copy link
Contributor

Hi there @jainv4156! This is the OpenCollective Notice for PRs merged from 2024-07-01 through 2024-07-31

If you are interested in compensation for this work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

Important

PLEASE NOTE: The process was updated in August 2024. Re-read the Payment Process page if you have not already.

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cleanup]: Fix Android Studio Warnings
4 participants